-
Notifications
You must be signed in to change notification settings - Fork 0
PLT-1445 Service module updates for AB2D adoption #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9a645ee to
9e171cd
Compare
414f667 to
909079b
Compare
909079b to
d22a45d
Compare
f0e3bf0
|
Changes have been made both to this PR and the related AB2D module PR - see the updated Tofu plans in the description. |
mjburling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the README.md with this change set? e.g. terraform-docs --config "$(git rev-parse --show-toplevel)/.terraform-docs.yml" . would be helpful.
| variable "platform_version" { | ||
| default = "1.4.0" | ||
| description = "Platform version on which to run your service. Only applicable for launch_type set to FARGATE." | ||
| type = string | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary.
- 1.4.0 was GA'd nearly 6 years
- If a platform version beyond 1.4.0 were released, it's not hard to imagine other aspects of this module needing to change to accommodate it. At that point, we'd increment the hard-coded platform version from 1.4.0 to the new version, and customers would adopt a whole new version of this module to take advantage of those features
- As a DASG platform, I think the aim is to primarily support ECS on Fargate for compute, with ancillary utilities implemented in Lambda.
Did you find that AB2D was using a platform version other than 1.4.0 where we needed to implement this?
🎫 Ticket
https://jira.cms.gov/browse/PLT-1445
🛠 Changes
This PR contains various updates that were required in order to migrate the AB2D contracts, events and worker services and service definitions onto the service module.
ℹ️ Context
This PR is part of a larger initiative to migrate existing Tofu code onto CDAP shared modules.
🧪 Validation
Tofu plan output for 20-microservices (AB2D-TEST)
Tofu plan output for 30-worker (AB2D-TEST)